Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 224663002: Fix problems in compact vm config that occurred during async tests. (Closed)

Created:
6 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 8 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix problems in compact vm config that occurred during async tests. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=34722

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M pkg/unittest/lib/compact_vm_config.dart View 6 chunks +21 lines, -19 lines 3 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/224663002/diff/1/pkg/unittest/lib/compact_vm_config.dart File pkg/unittest/lib/compact_vm_config.dart (left): https://codereview.chromium.org/224663002/diff/1/pkg/unittest/lib/compact_vm_config.dart#oldcode69 pkg/unittest/lib/compact_vm_config.dart:69: _pass--; the main problem was here. Results can also ...
6 years, 8 months ago (2014-04-03 22:39:38 UTC) #1
blois
lgtm https://codereview.chromium.org/224663002/diff/1/pkg/unittest/lib/compact_vm_config.dart File pkg/unittest/lib/compact_vm_config.dart (right): https://codereview.chromium.org/224663002/diff/1/pkg/unittest/lib/compact_vm_config.dart#newcode70 pkg/unittest/lib/compact_vm_config.dart:70: Set passing = new Set(); there's passing and ...
6 years, 8 months ago (2014-04-03 22:45:20 UTC) #2
Siggi Cherem (dart-lang)
thanks! https://codereview.chromium.org/224663002/diff/1/pkg/unittest/lib/compact_vm_config.dart File pkg/unittest/lib/compact_vm_config.dart (right): https://codereview.chromium.org/224663002/diff/1/pkg/unittest/lib/compact_vm_config.dart#newcode70 pkg/unittest/lib/compact_vm_config.dart:70: Set passing = new Set(); On 2014/04/03 22:45:21, ...
6 years, 8 months ago (2014-04-03 22:46:05 UTC) #3
Siggi Cherem (dart-lang)
6 years, 8 months ago (2014-04-03 22:48:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r34722 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698