Fix attempt to find metadata of a library with no metadata.

Fix attempt to find metadata of a library with no metadata.

BUG=12206
R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25930

[rmacnak, 2013-08-07 23:30:37]

https://codereview.chromium.org/22460008/diff/10001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/22460008/diff/10001/runtime/vm/parser.cc#newc...
runtime/vm/parser.cc:4746: intptr_t pre_metadata_pos = TokenPos();
Questionable name

[hausner, 2013-08-08 07:55:17]

LGTM with comments

https://codereview.chromium.org/22460008/diff/10001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/22460008/diff/10001/runtime/vm/parser.cc#newc...
runtime/vm/parser.cc:4746: intptr_t pre_metadata_pos = TokenPos();
How about naming it rewind_pos or fallback_pos?

On 2013/08/07 23:30:37, Ryan Macnak wrote:
> Questionable name

https://codereview.chromium.org/22460008/diff/10001/runtime/vm/parser.cc#newc...
runtime/vm/parser.cc:4757: SkipMetadata();
Even though we are not using the metadata for import/export yet, I think you
should do:

metadata_pos = SkipMetadata()

https://codereview.chromium.org/22460008/diff/10001/runtime/vm/parser.cc#newc...
runtime/vm/parser.cc:4763: SkipMetadata();
ditto

https://codereview.chromium.org/22460008/diff/10001/runtime/vm/parser.cc#newc...
runtime/vm/parser.cc:4777: SkipMetadata();
ditto

[rmacnak, 2013-08-08 16:49:28]

https://codereview.chromium.org/22460008/diff/10001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/22460008/diff/10001/runtime/vm/parser.cc#newc...
runtime/vm/parser.cc:4746: intptr_t pre_metadata_pos = TokenPos();
On 2013/08/08 07:55:17, hausner wrote:
> How about naming it rewind_pos or fallback_pos?
> 
> On 2013/08/07 23:30:37, Ryan Macnak wrote:
> > Questionable name
> 

Much better.

https://codereview.chromium.org/22460008/diff/10001/runtime/vm/parser.cc#newc...
runtime/vm/parser.cc:4757: SkipMetadata();
On 2013/08/08 07:55:17, hausner wrote:
> Even though we are not using the metadata for import/export yet, I think you
> should do:
> 
> metadata_pos = SkipMetadata()

Got 'em.

[rmacnak, 2013-08-08 16:50:17]

Committed patchset #2 manually as r25930 (presubmit successful).