Issue 22424008: Changes the flag for using far branches from static to volatile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22424008: Changes the flag for using far branches from static to volatile. (Closed)

Created:
7 years, 4 months ago by zra

Modified:
7 years, 4 months ago

Reviewers:
Florian Schneider, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Changes the flag for using far branches from static to volatile. R=fschneider@google.com, iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25967

Patch Set 1 #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	runtime/vm/compiler.cc	View		2 chunks	+2 lines, -3 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comment discussed offline. -Ivan https://codereview.chromium.org/22424008/diff/1/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/22424008/diff/1/runtime/vm/compiler.cc#newcode554 runtime/vm/compiler.cc:554: ASSERT(bailout_error.IsLanguageError()); We should ...

7 years, 4 months ago (2013-08-09 17:07:25 UTC) #3

zra

https://codereview.chromium.org/22424008/diff/1/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/22424008/diff/1/runtime/vm/compiler.cc#newcode554 runtime/vm/compiler.cc:554: ASSERT(bailout_error.IsLanguageError()); On 2013/08/09 17:07:25, Ivan Posva wrote: > We ...

7 years, 4 months ago (2013-08-09 17:12:20 UTC) #4

zra

7 years, 4 months ago (2013-08-09 17:23:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r25967 (presubmit successful).

Expand Messages | Collapse Messages