Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 22412002: Fix register allocation bug in building use intervals. (Closed)

Created:
7 years, 4 months ago by Florian Schneider
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, srdjan
Visibility:
Public.

Description

Fix register allocation bug in building use intervals. This bug was only exposed on ARM, but can be a problem on other platforms as well. When building the use intervals for a value that is used more than once at one instruction, the use interval was not adjusted correctly: Under certain conditions the resulting interval can be too short. It can occur when the first use is a writable register use, and the second use is a normal register use. This CL grows the use intervals to the correct size in that case. BUG=https://code.google.com/p/dart/issues/detail?id=11800 TEST=tests/language/regress_11800_test.dart R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=25810

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M runtime/vm/flow_graph_allocator.cc View 1 chunk +7 lines, -3 lines 0 comments Download
A tests/language/regress_11800_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
7 years, 4 months ago (2013-08-06 12:26:58 UTC) #1
Vyacheslav Egorov (Google)
lgtm
7 years, 4 months ago (2013-08-06 12:31:32 UTC) #2
Florian Schneider
7 years, 4 months ago (2013-08-06 12:43:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25810 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698