Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 224113003: Re-apply "Adding a mechanism to 'upgrade' the Dart type of elements" (Closed)

Created:
6 years, 8 months ago by blois
Modified:
6 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Re-apply "Adding a mechanism to 'upgrade' the Dart type of elements" With fixes for: - Expected analyzer static error in the unittest. - Added browser/interop.js to the HTML file BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=35080

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+559 lines, -161 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 5 chunks +80 lines, -27 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 7 chunks +116 lines, -67 lines 0 comments Download
A tests/html/custom/element_upgrade_test.dart View 1 chunk +132 lines, -0 lines 0 comments Download
A tests/html/custom/element_upgrade_test.html View 1 chunk +51 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 2 chunks +2 lines, -0 lines 0 comments Download
M tools/dom/src/dart2js_CustomElementSupport.dart View 2 chunks +58 lines, -1 line 0 comments Download
A tools/dom/src/dartium_CustomElementSupport.dart View 1 chunk +89 lines, -0 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 2 chunks +3 lines, -39 lines 0 comments Download
M tools/dom/src/shared_html.dart View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 2 chunks +2 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 2 chunks +17 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
https://codereview.chromium.org/224113003/diff/1/tests/html/custom/element_upgrade_test.html File tests/html/custom/element_upgrade_test.html (right): https://codereview.chromium.org/224113003/diff/1/tests/html/custom/element_upgrade_test.html#newcode49 tests/html/custom/element_upgrade_test.html:49: src="/packages/browser/interop.js"></script> Added interop.js https://codereview.chromium.org/224113003/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/224113003/diff/1/tests/html/html.status#newcode442 tests/html/html.status:442: ...
6 years, 8 months ago (2014-04-15 19:29:11 UTC) #1
Jennifer Messerly
lgtm! https://codereview.chromium.org/224113003/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/224113003/diff/1/tests/html/html.status#newcode442 tests/html/html.status:442: custom/element_upgrade_test: StaticWarning On 2014/04/15 19:29:12, blois wrote: > ...
6 years, 8 months ago (2014-04-15 19:34:43 UTC) #2
blois
https://codereview.chromium.org/224113003/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/224113003/diff/1/tests/html/html.status#newcode442 tests/html/html.status:442: custom/element_upgrade_test: StaticWarning On 2014/04/15 19:34:43, John Messerly wrote: > ...
6 years, 8 months ago (2014-04-15 20:47:43 UTC) #3
blois
6 years, 8 months ago (2014-04-15 20:50:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r35080 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698