Issue 22398008: Refactor and reorganize type inference classes before porting ConcreteTypesInferrer to InferrerVisi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22398008: Refactor and reorganize type inference classes before porting ConcreteTypesInferrer to InferrerVisi… (Closed)

Created:
7 years, 4 months ago by polux

Modified:
7 years, 4 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Refactor and reorganize type inference classes before porting ConcreteTypesInferrer to InferrerVisitor. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=26174

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+198 lines, -160 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart	View		1 chunk	+12 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/container_tracer.dart	View	1 2	6 chunks	+7 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart	View	1 2	4 chunks	+73 lines, -104 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View		4 chunks	+104 lines, -46 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/types.dart	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	tests/compiler/dart2js/cpa_inference_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

polux

I've extracted what's used of InferrerEngine in InferrerVisitor into a MininalInferrerEngine (that is, two methods). ...

7 years, 4 months ago (2013-08-09 09:36:18 UTC) #1

polux

7 years, 4 months ago (2013-08-15 09:00:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r26174 (presubmit successful).