Issue 22393002: First CL for removing our dependency on the checked-in binary for building

Issue 22393002: First CL for removing our dependency on the checked-in binary for building (Closed)

Created:
7 years, 4 months ago by kustermann

Modified:
7 years, 4 months ago

Reviewers:
ricow1, devoncarew

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

First CL for removing our dependency on the checked-in binary for building R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=25809

Patch Set 3 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -133 lines)			Patch
M	client/tools/buildbot_annotated_steps.py	View	1	5 chunks	+14 lines, -44 lines	0 comments	Download
M	editor/build/build.py	View	1	6 chunks	+9 lines, -25 lines	0 comments	Download
M	editor/build/create_analyzer.xml	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	editor/tools/compile_analyzer.py	View	1	5 chunks	+11 lines, -20 lines	0 comments	Download
M	runtime/dart-runtime.gyp	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/print_version.py	View		1 chunk	+7 lines, -3 lines	0 comments	Download
M	tools/utils.py	View	1 2	5 chunks	+57 lines, -20 lines	0 comments	Download
M	utils/compiler/create_snapshot.dart	View		1 chunk	+9 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://codereview.chromium.org/22393002/diff/17001/tools/utils.py File tools/utils.py (right): https://codereview.chromium.org/22393002/diff/17001/tools/utils.py#newcode242 tools/utils.py:242: if user == 'chrome-bot': add comment: # We ...

7 years, 4 months ago (2013-08-06 10:49:12 UTC) #2

kustermann

https://codereview.chromium.org/22393002/diff/17001/tools/utils.py File tools/utils.py (right): https://codereview.chromium.org/22393002/diff/17001/tools/utils.py#newcode242 tools/utils.py:242: if user == 'chrome-bot': On 2013/08/06 10:49:12, ricow1 wrote: ...

7 years, 4 months ago (2013-08-06 10:52:44 UTC) #3

kustermann

Committed patchset #3 manually as r25809 (presubmit successful).

7 years, 4 months ago (2013-08-06 10:53:36 UTC) #4

Message was sent while issue was closed.

@devon: Just FYI.

Expand Messages | Collapse Messages