Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 22392006: Do not generate calls to Dart_EnterScope/Dart_ExitScope around native (Closed)

Created:
7 years, 4 months ago by siva
Modified:
7 years, 4 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not generate calls to Dart_EnterScope/Dart_ExitScope around native callbacks as an ApiLocalScope is auto created by the VM when making external native calls. R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=25846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/dom/scripts/systemnative.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 4 months ago (2013-08-06 20:49:47 UTC) #1
vsm
lgtm
7 years, 4 months ago (2013-08-06 23:18:08 UTC) #2
siva
7 years, 4 months ago (2013-08-06 23:58:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25846 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698