Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 22389004: Allows compiler bailout to handle errors of any type. (Closed)

Created:
7 years, 4 months ago by zra
Modified:
7 years, 4 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allows compiler bailout to handle errors of any type. R=asiva@google.com, iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25974

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -17 lines) Patch
M runtime/vm/assembler_arm.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/compiler.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M runtime/vm/object.h View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
zra
7 years, 4 months ago (2013-08-09 18:11:10 UTC) #1
siva
lgtm https://codereview.chromium.org/22389004/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/22389004/diff/1/runtime/vm/object.cc#newcode576 runtime/vm/object.cc:576: *smi_illegal_cid_ = Smi::New(kIllegalCid); String& error_str = String::Handle(); error_str ...
7 years, 4 months ago (2013-08-09 18:54:03 UTC) #2
Ivan Posva
LGTM after addressing Siva's comment. -Ivan
7 years, 4 months ago (2013-08-09 19:05:56 UTC) #3
zra
https://codereview.chromium.org/22389004/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/22389004/diff/1/runtime/vm/object.cc#newcode576 runtime/vm/object.cc:576: *smi_illegal_cid_ = Smi::New(kIllegalCid); On 2013/08/09 18:54:03, siva wrote: > ...
7 years, 4 months ago (2013-08-09 19:50:36 UTC) #4
zra
7 years, 4 months ago (2013-08-09 19:51:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r25974 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698