Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 22375012: pkg/serialization updates (Closed)

Created:
7 years, 4 months ago by kevmoo-old
Modified:
7 years, 4 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/serialization updates Serialiation.rules is now publicly unmodifiable More return types locked down some fields with final R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=26071

Patch Set 1 #

Patch Set 2 : a bit more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -40 lines) Patch
M pkg/serialization/lib/serialization.dart View 3 chunks +13 lines, -7 lines 0 comments Download
M pkg/serialization/lib/src/basic_rule.dart View 1 3 chunks +19 lines, -22 lines 0 comments Download
M pkg/serialization/lib/src/serialization_rule.dart View 9 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kevmoo-old
PTAL
7 years, 4 months ago (2013-08-11 00:53:31 UTC) #1
Alan Knight
lgtm
7 years, 4 months ago (2013-08-13 18:12:19 UTC) #2
kevmoo-old
7 years, 4 months ago (2013-08-13 18:23:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r26071 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698