Consistently schedule operations in the barback tests.

Consistently schedule operations in the barback tests.

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25978

[Bob Nystrom, 2013-08-08 21:35:35]

https://codereview.chromium.org/22371005/diff/1/pkg/barback/test/package_grap...
File pkg/barback/test/package_graph/transform_test.dart (right):

https://codereview.chromium.org/22371005/diff/1/pkg/barback/test/package_grap...
pkg/barback/test/package_graph/transform_test.dart:350: // Wait for the
transform to start.
This comment is unneeded now. Here and below.

https://codereview.chromium.org/22371005/diff/1/pkg/barback/test/transformer/...
File pkg/barback/test/transformer/mock.dart (right):

https://codereview.chromium.org/22371005/diff/1/pkg/barback/test/transformer/...
pkg/barback/test/transformer/mock.dart:26: /// that this is called.
Scheduled getters feel a bit magical to me. What made you decide to go this way?

https://codereview.chromium.org/22371005/diff/1/pkg/barback/test/utils.dart
File pkg/barback/test/utils.dart (right):

https://codereview.chromium.org/22371005/diff/1/pkg/barback/test/utils.dart#n...
pkg/barback/test/utils.dart:82: /// parsed as one. Note that this method is not
automatically scheduled.
Remove the "Note that..." sentence and collapse the next one into this
paragraph.

https://codereview.chromium.org/22371005/diff/1/pkg/barback/test/utils.dart#n...
pkg/barback/test/utils.dart:104: /// Unlike [removeSources], this is not
automatically scheduled and will be run
Nit, but make this part of previous paragraph.

[nweiz, 2013-08-09 19:41:51]

https://codereview.chromium.org/22371005/diff/1/pkg/barback/test/package_grap...
File pkg/barback/test/package_graph/transform_test.dart (right):

https://codereview.chromium.org/22371005/diff/1/pkg/barback/test/package_grap...
pkg/barback/test/package_graph/transform_test.dart:350: // Wait for the
transform to start.
On 2013/08/08 21:35:35, Bob Nystrom wrote:
> This comment is unneeded now. Here and below.

Done.

https://codereview.chromium.org/22371005/diff/1/pkg/barback/test/transformer/...
File pkg/barback/test/transformer/mock.dart (right):

https://codereview.chromium.org/22371005/diff/1/pkg/barback/test/transformer/...
pkg/barback/test/transformer/mock.dart:26: /// that this is called.
On 2013/08/08 21:35:35, Bob Nystrom wrote:
> Scheduled getters feel a bit magical to me. What made you decide to go this
way?

Every place this was used, it was wrapped in [schedule]. It only makes sense to
access it after other scheduled operations. It seemed silly to require manual
wrapping.

The scheduled getters in ScheduledServer seem to have worked out okay.

https://codereview.chromium.org/22371005/diff/1/pkg/barback/test/utils.dart
File pkg/barback/test/utils.dart (right):

https://codereview.chromium.org/22371005/diff/1/pkg/barback/test/utils.dart#n...
pkg/barback/test/utils.dart:82: /// parsed as one. Note that this method is not
automatically scheduled.
On 2013/08/08 21:35:35, Bob Nystrom wrote:
> Remove the "Note that..." sentence and collapse the next one into this
> paragraph.

Done.

https://codereview.chromium.org/22371005/diff/1/pkg/barback/test/utils.dart#n...
pkg/barback/test/utils.dart:104: /// Unlike [removeSources], this is not
automatically scheduled and will be run
On 2013/08/08 21:35:35, Bob Nystrom wrote:
> Nit, but make this part of previous paragraph.

Done.

[Bob Nystrom, 2013-08-09 20:14:06]

Okey-dokey. LGTM.

[nweiz, 2013-08-09 20:36:05]

Committed patchset #2 manually as r25978 (presubmit successful).