Issue 223703002: Add DART_BUILD_NOTIFICATION_DELAY to control notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 223703002: Add DART_BUILD_NOTIFICATION_DELAY to control notifications (Closed)

Created:
6 years, 8 months ago by ahe

Modified:
6 years, 8 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add DART_BUILD_NOTIFICATION_DELAY to control notifications BUG=http://dartbug.com/17965 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=34691

Patch Set 2 : Address comments #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	dart/tools/build.py	View	1	4 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

lgtm https://codereview.chromium.org/223703002/diff/1/dart/tools/build.py File dart/tools/build.py (right): https://codereview.chromium.org/223703002/diff/1/dart/tools/build.py#newcode315 dart/tools/build.py:315: if time.time() - start < notification_delay: I would ...

6 years, 8 months ago (2014-04-03 11:00:58 UTC) #2

ahe

Thanks, Rico! https://codereview.chromium.org/223703002/diff/1/dart/tools/build.py File dart/tools/build.py (right): https://codereview.chromium.org/223703002/diff/1/dart/tools/build.py#newcode315 dart/tools/build.py:315: if time.time() - start < notification_delay: On ...

6 years, 8 months ago (2014-04-03 11:08:49 UTC) #3

ahe

6 years, 8 months ago (2014-04-03 11:09:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r34691 (presubmit successful).

Expand Messages | Collapse Messages

Issue 223703002: Add DART_BUILD_NOTIFICATION_DELAY to control notifications (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments #

Messages