Issue 22370006: Fix inconsistent equality with doubles and large integers on ia32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22370006: Fix inconsistent equality with doubles and large integers on ia32. (Closed)

Created:
7 years, 4 months ago by Florian Schneider

Modified:
7 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org, floitsch

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix inconsistent equality with doubles and large integers on ia32. For numbers a == b should be the same as b == a. This is done by avoiding generating 80-bit precision x87 FP code. x64 and Mac OS already compile using SSE2. BUG=https://code.google.com/p/dart/issues/detail?id=8829 TEST=tests/language/large_integer_equality_vm_test.dart R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25914

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -1 line)			Patch
A	tests/language/large_integer_equality_vm_test.dart	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	tools/gyp/configurations_make.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gyp/configurations_msvs.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

7 years, 4 months ago (2013-08-08 07:43:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r25914 (presubmit successful).

Expand Messages | Collapse Messages