Issue 223673007: Move mirrors-test from dart2js_extra to lib/mirrors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 223673007: Move mirrors-test from dart2js_extra to lib/mirrors. (Closed)

Created:
6 years, 8 months ago by floitsch

Modified:
6 years, 8 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Move mirrors-test from dart2js_extra to lib/mirrors. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=34728

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -17 lines)			Patch
D	tests/compiler/dart2js_extra/mirrors_test.dart	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	tests/lib/mirrors/dart2js_mirrors_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/mirrors/mirrors_test.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

floitsch

I frequently run the tests in lib/mirrors to make sure I didn't break anything. Since ...

6 years, 8 months ago (2014-04-03 19:17:05 UTC) #1

ahe

LGTM. An alternative approach: tests/lib/mirrors/typedef_test.dart

6 years, 8 months ago (2014-04-04 08:54:48 UTC) #2

floitsch

I considered that, but since mirror-tests are so slow I ended up keeping them in ...

6 years, 8 months ago (2014-04-04 09:45:22 UTC) #3

floitsch

6 years, 8 months ago (2014-04-04 09:48:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r34728 (presubmit successful).