Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2235683003: Correct description in messages; add 'tel' input type (Closed)

Created:
4 years, 4 months ago by Pam (message me for reviews)
Modified:
4 years, 4 months ago
Reviewers:
emilyschechter
Base URL:
https://chromium.googlesource.com/chromium/extensions-by-google.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Correct description in messages; add 'tel' input type Move description.txt to its proper place in the i18n messages file, and add the 'tel' input data type. BUG=615448 R=emilyschechter@chromium.org Committed: https://chromium.googlesource.com/chromium/extensions-by-google/32d0872be299d461f6a5ef7203f33140d05f9ff1

Patch Set 1 #

Patch Set 2 : Ignore existing icons/ directory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M go-back-with-backspace/_locales/en/messages.json View 1 chunk +1 line, -1 line 0 comments Download
M go-back-with-backspace/build-zip.sh View 1 1 chunk +1 line, -1 line 0 comments Download
D go-back-with-backspace/description.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M go-back-with-backspace/is_editable.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (3 generated)
emilyschechter
lgtm
4 years, 4 months ago (2016-08-10 21:05:43 UTC) #3
Pam (message me for reviews)
4 years, 4 months ago (2016-08-10 21:44:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
32d0872be299d461f6a5ef7203f33140d05f9ff1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698