Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 22339023: Fix for issue 11497- liberalize warnings about bad overrides (Closed)

Created:
7 years, 4 months ago by jwren
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for issue 11497- liberalize warnings about bad overrides TODO- This is all of the changes in the analyzer, before this lands however the status files will need to be updated with now 30 failing language/co19 tests. R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=26018

Patch Set 1 #

Patch Set 2 : Update status files #

Total comments: 4

Patch Set 3 : Tweaks to the status files #

Messages

Total messages: 6 (0 generated)
jwren
https://code.google.com/p/dart/issues/detail?id=11497
7 years, 4 months ago (2013-08-09 22:58:29 UTC) #1
Brian Wilkerson
LGTM
7 years, 4 months ago (2013-08-10 14:52:10 UTC) #2
jwren
On 2013/08/10 14:52:10, Brian Wilkerson wrote: > LGTM Konstantin- PTAL
7 years, 4 months ago (2013-08-12 18:22:07 UTC) #3
scheglov
LGTM for code. Please tweak the status files. https://codereview.chromium.org/22339023/diff/5001/tests/co19/co19-analyzer.status File tests/co19/co19-analyzer.status (right): https://codereview.chromium.org/22339023/diff/5001/tests/co19/co19-analyzer.status#newcode133 tests/co19/co19-analyzer.status:133: # ...
7 years, 4 months ago (2013-08-12 18:26:27 UTC) #4
jwren
Thanks Konstantin! https://codereview.chromium.org/22339023/diff/5001/tests/co19/co19-analyzer.status File tests/co19/co19-analyzer.status (right): https://codereview.chromium.org/22339023/diff/5001/tests/co19/co19-analyzer.status#newcode133 tests/co19/co19-analyzer.status:133: # co19 issue 486- some override errors ...
7 years, 4 months ago (2013-08-12 18:34:12 UTC) #5
jwren
7 years, 4 months ago (2013-08-12 18:35:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r26018 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698