Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 223373004: Revert "Load deferred chunks in the right order." (Closed)

Created:
6 years, 8 months ago by sigurdm
Modified:
6 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Load deferred chunks in the right order." This reverts commit 34698. Committed: https://code.google.com/p/dart/source/detail?r=34702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -152 lines) Patch
M sdk/lib/_internal/compiler/implementation/deferred_load.dart View 3 chunks +9 lines, -34 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart View 1 chunk +7 lines, -12 lines 0 comments Download
M sdk/lib/_internal/lib/async_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/lib/js_helper.dart View 5 chunks +28 lines, -23 lines 0 comments Download
M sdk/lib/async/deferred_load.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart View 1 chunk +13 lines, -25 lines 0 comments Download
M tests/compiler/dart2js_extra/deferred/deferred_class_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_extra/deferred/deferred_constant2_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js_extra/deferred/deferred_constant3_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js_extra/deferred/deferred_constant4_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js_extra/deferred/deferred_function_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
D tests/compiler/dart2js_extra/deferred/deferred_overlapping_lib1.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/compiler/dart2js_extra/deferred/deferred_overlapping_lib2.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/compiler/dart2js_extra/deferred/deferred_overlapping_lib3.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/compiler/dart2js_extra/deferred/deferred_overlapping_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
A + tests/lib/async/deferred/deferred_api_library.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/lib/async/deferred/deferred_api_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download
M tests/lib/async/deferred/deferred_fail_to_load_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/deferred/deferred_in_isolate_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/lib/async/deferred/deferred_library.dart View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sigurdm
tbr
6 years, 8 months ago (2014-04-03 12:46:52 UTC) #1
sigurdm
Committed patchset #1 manually as r34702 (presubmit successful).
6 years, 8 months ago (2014-04-03 12:47:36 UTC) #2
sigurdm
6 years, 8 months ago (2014-04-03 12:48:14 UTC) #3
floitsch
6 years, 8 months ago (2014-04-03 12:53:17 UTC) #4
Message was sent while issue was closed. 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698