Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 22335005: Fix Issue 12322: the analysis requires stored guarded_cid to be returned when requested; only when … (Closed)

Created:
7 years, 4 months ago by srdjan
Modified:
7 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Vyacheslav Egorov (Google), vm-dev_dartlang.org
Visibility:
Public.

Description

Fix Issue 12322: the analysis requires stored guarded_cid to be returned when requested; only when computing result of LoadField instruction should we not trust guarded_cid for externalizable cids. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M runtime/vm/flow_graph_type_propagator.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
7 years, 4 months ago (2013-08-08 18:03:19 UTC) #1
Cutch
lgtm
7 years, 4 months ago (2013-08-08 18:08:54 UTC) #2
srdjan
7 years, 4 months ago (2013-08-08 18:31:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25938 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698