make dart2js_info strong-mode clean

make dart2js_info strong-mode clean

R=sigmund@google.com

Committed: https://github.com/dart-lang/dart2js_info/commit/2cb640a0d35be03bea2001d911358e4261cbe9ff

[Harry Terkelsen, 2016-08-10 21:25:03]

het@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-08-10 21:40:28]

https://codereview.chromium.org/2233093003/diff/1/lib/json_info_codec.dart
File lib/json_info_codec.dart (right):

https://codereview.chromium.org/2233093003/diff/1/lib/json_info_codec.dart#ne...
lib/json_info_codec.dart:18: (elements['library'] as Map<String,
Map>).values.map(parseLibrary));
I believe the way json is parsed that this and the casts below wo;; fail when
strong mode checks are added to the program (elements['library'] is likely just
Map<dynamic, dynamic>).

Maybe we need to do:
  elements['class'].values.map/*<ClassInfo>*/((c) => parseClass(c as Map));

it might be worth seeing if DDC could one day add that cast automatically
though.

https://codereview.chromium.org/2233093003/diff/1/lib/json_info_codec.dart#ne...
lib/json_info_codec.dart:70: result.imports.addAll((json['imports'] as
List<String>) ?? const []);
same here and below, I think this cast will fail unfortunately.

https://codereview.chromium.org/2233093003/diff/1/lib/json_info_codec.dart#ne...
lib/json_info_codec.dart:317: if (info.outputUnit != null)
let's add braces here now that it doesn't fit on a single line

https://codereview.chromium.org/2233093003/diff/1/lib/json_info_codec.dart#ne...
lib/json_info_codec.dart:357: if (info.initializer != null)
same here

https://codereview.chromium.org/2233093003/diff/1/lib/json_info_codec.dart#ne...
lib/json_info_codec.dart:385: Map _visitMeasurements(Measurements measurements)
{
FYI - I deleted the measurements code in d2js, so we can delete this here too if
we want.

[Harry Terkelsen, 2016-08-10 22:18:28]

https://codereview.chromium.org/2233093003/diff/1/lib/json_info_codec.dart
File lib/json_info_codec.dart (right):

https://codereview.chromium.org/2233093003/diff/1/lib/json_info_codec.dart#ne...
lib/json_info_codec.dart:18: (elements['library'] as Map<String,
Map>).values.map(parseLibrary));
On 2016/08/10 21:40:28, Siggi Cherem (dart-lang) wrote:
> I believe the way json is parsed that this and the casts below wo;; fail when
> strong mode checks are added to the program (elements['library'] is likely
just
> Map<dynamic, dynamic>).
> 
> Maybe we need to do:
>   elements['class'].values.map/*<ClassInfo>*/((c) => parseClass(c as Map));
> 
> it might be worth seeing if DDC could one day add that cast automatically
> though.

Done.

https://codereview.chromium.org/2233093003/diff/1/lib/json_info_codec.dart#ne...
lib/json_info_codec.dart:70: result.imports.addAll((json['imports'] as
List<String>) ?? const []);
On 2016/08/10 21:40:28, Siggi Cherem (dart-lang) wrote:
> same here and below, I think this cast will fail unfortunately.

Done.

https://codereview.chromium.org/2233093003/diff/1/lib/json_info_codec.dart#ne...
lib/json_info_codec.dart:317: if (info.outputUnit != null)
On 2016/08/10 21:40:28, Siggi Cherem (dart-lang) wrote:
> let's add braces here now that it doesn't fit on a single line

Done.

https://codereview.chromium.org/2233093003/diff/1/lib/json_info_codec.dart#ne...
lib/json_info_codec.dart:357: if (info.initializer != null)
On 2016/08/10 21:40:28, Siggi Cherem (dart-lang) wrote:
> same here

Done.

https://codereview.chromium.org/2233093003/diff/1/lib/json_info_codec.dart#ne...
lib/json_info_codec.dart:385: Map _visitMeasurements(Measurements measurements)
{
On 2016/08/10 21:40:28, Siggi Cherem (dart-lang) wrote:
> FYI - I deleted the measurements code in d2js, so we can delete this here too
if
> we want.

Acknowledged.

[Siggi Cherem (dart-lang), 2016-08-10 22:33:33]

lgtm

[Harry Terkelsen, 2016-08-10 22:36:15]

Description was changed from

==========
make dart2js_info strong-mode clean
==========

to

==========
make dart2js_info strong-mode clean

R=sigmund@google.com

Committed:
https://github.com/dart-lang/dart2js_info/commit/2cb640a0d35be03bea2001d91135...
==========

[Harry Terkelsen, 2016-08-10 22:36:16]

Committed patchset #3 (id:40001) manually as
2cb640a0d35be03bea2001d911358e4261cbe9ff (presubmit successful).