Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 22325013: Remove dart:io dependency from scanner/ast/parser tests. (Closed)

Created:
7 years, 4 months ago by scheglov
Modified:
7 years, 4 months ago
Reviewers:
ricow1, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove dart:io dependency from scanner/ast/parser tests. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=25935

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/scanner_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 4 months ago (2013-08-08 16:40:56 UTC) #1
Brian Wilkerson
LGTM
7 years, 4 months ago (2013-08-08 16:43:42 UTC) #2
scheglov
7 years, 4 months ago (2013-08-08 17:46:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25935 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698