Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 223053004: lib/convert: removed unused import, removed redundant test (Closed)

Created:
6 years, 8 months ago by kevmoo
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

lib/convert: removed unused import, removed redundant test Re-enabled checks in existing test R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=34703

Patch Set 1 #

Patch Set 2 : removed status file entry #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -172 lines) Patch
M sdk/lib/convert/convert.dart View 1 chunk +0 lines, -1 line 0 comments Download
D tests/lib/convert/json2_test.dart View 1 chunk +0 lines, -167 lines 0 comments Download
M tests/lib/convert/json_lib_test.dart View 1 chunk +2 lines, -3 lines 2 comments Download
M tests/lib/lib.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kevmoo
I did a diff to make sure everything was covered in json_lib_test and json_toEncodable removed ...
6 years, 8 months ago (2014-04-03 00:39:03 UTC) #1
ricow1
+floitsch, +devoncarew LGTM, but I know I had a discussion with Lasse and Florian about ...
6 years, 8 months ago (2014-04-03 05:29:22 UTC) #2
devoncarew
https://codereview.chromium.org/223053004/diff/20001/tests/lib/convert/json_lib_test.dart File tests/lib/convert/json_lib_test.dart (left): https://codereview.chromium.org/223053004/diff/20001/tests/lib/convert/json_lib_test.dart#oldcode84 tests/lib/convert/json_lib_test.dart:84: // TODO(devoncarew): these tests break the dartium build On ...
6 years, 8 months ago (2014-04-03 07:24:28 UTC) #3
ricow1
I talked with Florian, this is unrelated to the old discussion, so LGTM
6 years, 8 months ago (2014-04-03 09:47:39 UTC) #4
kevmoo
6 years, 8 months ago (2014-04-03 13:42:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r34703 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698