Issue 223023003: Extract an http_parser package from shelf.

Issue 223023003: Extract an http_parser package from shelf. (Closed)

Created:
6 years, 8 months ago by nweiz

Modified:
6 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Extract an http_parser package from shelf. This will allow HTTP format parsing to be shared between shelf and the http package, as well as potentially other packages. R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=34680

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -805 lines)			Patch
A	pkg/http_parser/README.md	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
A +	pkg/http_parser/lib/http_parser.dart	View		2 chunks	+4 lines, -8 lines	0 comments	Download
A +	pkg/http_parser/lib/src/media_type.dart	View		2 chunks	+4 lines, -1 line	0 comments	Download
A +	pkg/http_parser/pubspec.yaml	View		1 chunk	+5 lines, -2 lines	0 comments	Download
A +	pkg/http_parser/test/http_date_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	pkg/http_parser/test/media_type_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
D	pkg/shelf/lib/src/media_type.dart	View		1 chunk	+0 lines, -158 lines	0 comments	Download
M	pkg/shelf/lib/src/message.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/shelf/lib/src/request.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/shelf/lib/src/response.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/shelf/lib/src/util.dart	View		1 chunk	+0 lines, -147 lines	0 comments	Download
M	pkg/shelf/pubspec.yaml	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	pkg/shelf/test/http_date_test.dart	View		1 chunk	+0 lines, -315 lines	0 comments	Download
D	pkg/shelf/test/media_type_test.dart	View		1 chunk	+0 lines, -163 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kevmoo

LGTM Love it. https://codereview.chromium.org/223023003/diff/1/pkg/http_parser/README.md File pkg/http_parser/README.md (right): https://codereview.chromium.org/223023003/diff/1/pkg/http_parser/README.md#newcode3 pkg/http_parser/README.md:3: the server, and thus avoids referencing ...

6 years, 8 months ago (2014-04-03 00:13:07 UTC) #2

nweiz

https://codereview.chromium.org/223023003/diff/1/pkg/http_parser/README.md File pkg/http_parser/README.md (right): https://codereview.chromium.org/223023003/diff/1/pkg/http_parser/README.md#newcode3 pkg/http_parser/README.md:3: the server, and thus avoids referencing any types from ...

6 years, 8 months ago (2014-04-03 00:51:17 UTC) #3

nweiz

6 years, 8 months ago (2014-04-03 00:54:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r34680 (presubmit successful).

Expand Messages | Collapse Messages