Issue 22300007: Compute the correct signature for default constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22300007: Compute the correct signature for default constructors. (Closed)

Created:
7 years, 4 months ago by ahe

Modified:
7 years, 4 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Compute the correct signature for default constructors. BUG=http://dartbug.com/12118 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=25881

Patch Set 1 : #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -14 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	2 chunks	+9 lines, -2 lines	1 comment	Download
M	dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 chunk	+2 lines, -3 lines	0 comments	Download
A +	dart/tests/language/crash_12118_test.dart	View	1 chunk	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

Committed patchset #1 manually as r25881 (presubmit successful).

7 years, 4 months ago (2013-08-07 15:59:10 UTC) #3

ngeoffray

7 years, 4 months ago (2013-08-08 21:55:24 UTC) #4

Message was sent while issue was closed.

LGTM! Thanks Peter.

https://codereview.chromium.org/22300007/diff/3001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart
(right):

https://codereview.chromium.org/22300007/diff/3001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1406:
this.isDefaultConstructor)
Did you consider a named parameter?

Expand Messages | Collapse Messages