Expose classes, codes, functions, and libraries collections.

Expose classes, codes, functions, and libraries collections.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25900

[Ivan Posva, 2013-08-07 00:39:11]

LGTM with comment.

-Ivan

https://codereview.chromium.org/22297008/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/22297008/diff/1/runtime/vm/service.cc#newcode271
runtime/vm/service.cc:271: if (!obj.IsCode()) {
This code is duplicated across multiple functions here:
if (js->num_arguments() == 1) {
  PrintCollectionErrorResponse("codes", js);
  return;
}
ASSERT(js->num_arguments() >= 2);
ObjectIdRing* ring = isolate->object_id_ring();
ASSERT(ring != NULL);
intptr_t id = atoi(js->GetArgument(1));
Object& obj = Object::Handle(ring->GetObjectForId(id));

You should abstract that out somehow.

[Cutch, 2013-08-07 14:47:48]

https://codereview.chromium.org/22297008/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/22297008/diff/1/runtime/vm/service.cc#newcode271
runtime/vm/service.cc:271: if (!obj.IsCode()) {
On 2013/08/07 00:39:11, Ivan Posva wrote:
> This code is duplicated across multiple functions here:
> if (js->num_arguments() == 1) {
>   PrintCollectionErrorResponse("codes", js);
>   return;
> }
> ASSERT(js->num_arguments() >= 2);
> ObjectIdRing* ring = isolate->object_id_ring();
> ASSERT(ring != NULL);
> intptr_t id = atoi(js->GetArgument(1));
> Object& obj = Object::Handle(ring->GetObjectForId(id));
> 
> You should abstract that out somehow.

Done.

[Cutch, 2013-08-07 20:35:54]

Committed patchset #4 manually as r25900 (presubmit successful).