Add support for Intl.select

Add support for Intl.select

Moves some of the validation logic into the appropriate objects, so we can more easily deal with Select, which takes its arguments in a Map, versus Plural/Gender which expect named arguments.

R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25965

[Emily Fortuna, 2013-08-08 23:49:55]

lgtm with a few comments.

https://codereview.chromium.org/22286013/diff/1/pkg/intl/lib/intl.dart
File pkg/intl/lib/intl.dart (right):

https://codereview.chromium.org/22286013/diff/1/pkg/intl/lib/intl.dart#newcod...
pkg/intl/lib/intl.dart:318: Intl.select(choice, cases),
indent this stuff +2 more spaces.

https://codereview.chromium.org/22286013/diff/1/pkg/intl/lib/src/intl_message...
File pkg/intl/lib/src/intl_message.dart (right):

https://codereview.chromium.org/22286013/diff/1/pkg/intl/lib/src/intl_message...
pkg/intl/lib/src/intl_message.dart:588: * Create a new [Select] providing
[mainArgument] and the list of possible
what types can mainArgument be since it's not typed in the signature?

https://codereview.chromium.org/22286013/diff/1/pkg/intl/lib/src/intl_message...
pkg/intl/lib/src/intl_message.dart:619: Map
argumentsOfInterestFor(MethodInvocation node) {
should this actually be private? It seems more like a helper function.

[Alan Knight, 2013-08-09 17:08:09]

Committed patchset #2 manually as r25965 (presubmit successful).

[Alan Knight, 2013-08-09 17:09:16]

https://codereview.chromium.org/22286013/diff/1/pkg/intl/lib/intl.dart
File pkg/intl/lib/intl.dart (right):

https://codereview.chromium.org/22286013/diff/1/pkg/intl/lib/intl.dart#newcod...
pkg/intl/lib/intl.dart:318: Intl.select(choice, cases),
On 2013/08/08 23:49:55, Emily Fortuna wrote:
> indent this stuff +2 more spaces.

Done.

https://codereview.chromium.org/22286013/diff/1/pkg/intl/lib/src/intl_message...
File pkg/intl/lib/src/intl_message.dart (right):

https://codereview.chromium.org/22286013/diff/1/pkg/intl/lib/src/intl_message...
pkg/intl/lib/src/intl_message.dart:588: * Create a new [Select] providing
[mainArgument] and the list of possible
On 2013/08/08 23:49:55, Emily Fortuna wrote:
> what types can mainArgument be since it's not typed in the signature?

It's a String. On the superclass it's typed as a field, and the
super-constructor just has it as this., where convention is to omit the type.
But I'll add it here for clarity.

https://codereview.chromium.org/22286013/diff/1/pkg/intl/lib/src/intl_message...
pkg/intl/lib/src/intl_message.dart:619: Map
argumentsOfInterestFor(MethodInvocation node) {
On 2013/08/08 23:49:55, Emily Fortuna wrote:
> should this actually be private? It seems more like a helper function.

It's somewhat of a helper, but it's a helper for the extract_messages code which
is a separate library, to get the arguments when they might be passed as named
arguments or might be a map, depending on the type of operation. So it's called
externally and can't be private.