Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 22286009: Added back abstract class change and fixed test (Closed)

Created:
7 years, 4 months ago by Tate Mandel
Modified:
7 years, 4 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, janicejl
Visibility:
Public.

Description

Added back abstract class change and fixed test BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=25939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -26 lines) Patch
M pkg/docgen/lib/docgen.dart View 10 chunks +41 lines, -24 lines 0 comments Download
M pkg/docgen/test/single_library_test.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tate Mandel
The changes to docgen.dart are no different than the last CL, but this time the ...
7 years, 4 months ago (2013-08-08 18:44:40 UTC) #1
Emily Fortuna
ah yes, adjusting the test will help! :-) lgtm
7 years, 4 months ago (2013-08-08 18:47:37 UTC) #2
Tate Mandel
7 years, 4 months ago (2013-08-08 19:32:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25939 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698