Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 222843003: Convert shelf to use the string_scanner package. (Closed)

Created:
6 years, 8 months ago by nweiz
Modified:
6 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Convert shelf to use the string_scanner package. This also adds support for [StringScanner.error], which produces a nicely-formatted scanning error. R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=34669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -576 lines) Patch
M pkg/shelf/lib/src/media_type.dart View 2 chunks +33 lines, -31 lines 0 comments Download
D pkg/shelf/lib/src/string_scanner.dart View 1 chunk +0 lines, -69 lines 0 comments Download
M pkg/shelf/lib/src/util.dart View 3 chunks +72 lines, -71 lines 0 comments Download
M pkg/shelf/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/shelf/test/harness_console.dart View 2 chunks +0 lines, -2 lines 0 comments Download
D pkg/shelf/test/string_scanner_test.dart View 1 chunk +0 lines, -266 lines 0 comments Download
M pkg/string_scanner/lib/string_scanner.dart View 3 chunks +56 lines, -7 lines 0 comments Download
D pkg/string_scanner/test/error_format_test.dart View 1 chunk +0 lines, -110 lines 0 comments Download
A pkg/string_scanner/test/error_test.dart View 1 chunk +168 lines, -0 lines 0 comments Download
A + pkg/string_scanner/test/expect_error_test.dart View 10 chunks +14 lines, -20 lines 0 comments Download
A pkg/string_scanner/test/utils.dart View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 8 months ago (2014-04-02 20:41:13 UTC) #1
kevmoo
lgtm
6 years, 8 months ago (2014-04-02 20:52:42 UTC) #2
nweiz
6 years, 8 months ago (2014-04-02 20:58:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34669 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698