Issue 222843003: Convert shelf to use the string_scanner package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 222843003: Convert shelf to use the string_scanner package. (Closed)

Created:
6 years, 8 months ago by nweiz

Modified:
6 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Convert shelf to use the string_scanner package. This also adds support for [StringScanner.error], which produces a nicely-formatted scanning error. R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=34669

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+361 lines, -576 lines)			Patch
M	pkg/shelf/lib/src/media_type.dart	View	2 chunks	+33 lines, -31 lines	0 comments	Download
D	pkg/shelf/lib/src/string_scanner.dart	View	1 chunk	+0 lines, -69 lines	0 comments	Download
M	pkg/shelf/lib/src/util.dart	View	3 chunks	+72 lines, -71 lines	0 comments	Download
M	pkg/shelf/pubspec.yaml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/shelf/test/harness_console.dart	View	2 chunks	+0 lines, -2 lines	0 comments	Download
D	pkg/shelf/test/string_scanner_test.dart	View	1 chunk	+0 lines, -266 lines	0 comments	Download
M	pkg/string_scanner/lib/string_scanner.dart	View	3 chunks	+56 lines, -7 lines	0 comments	Download
D	pkg/string_scanner/test/error_format_test.dart	View	1 chunk	+0 lines, -110 lines	0 comments	Download
A	pkg/string_scanner/test/error_test.dart	View	1 chunk	+168 lines, -0 lines	0 comments	Download
A +	pkg/string_scanner/test/expect_error_test.dart	View	10 chunks	+14 lines, -20 lines	0 comments	Download
A	pkg/string_scanner/test/utils.dart	View	1 chunk	+17 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

nweiz

6 years, 8 months ago (2014-04-02 20:58:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r34669 (presubmit successful).