Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 222763002: Code cleanup in _NumberFormatParser (Closed)

Created:
6 years, 8 months ago by sra1
Modified:
6 years, 8 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Code cleanup in _NumberFormatParser - avoid null values in fields - streamline _StringIterator R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=34678

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -36 lines) Patch
M pkg/intl/lib/number_format.dart View 8 chunks +40 lines, -36 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
6 years, 8 months ago (2014-04-03 00:10:04 UTC) #1
Alan Knight
lgtm
6 years, 8 months ago (2014-04-03 00:24:40 UTC) #2
sra1
6 years, 8 months ago (2014-04-03 00:27:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r34678 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698