Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22265002: Support cross-package transforms in barback. (Closed)

Created:
7 years, 4 months ago by nweiz
Modified:
7 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support cross-package transforms in barback. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=25937

Patch Set 1 #

Patch Set 2 : Add a missing import. #

Patch Set 3 : Another missing import. #

Patch Set 4 : Remove a duplicated test. #

Total comments: 4

Patch Set 5 : Code review changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -92 lines) Patch
M pkg/barback/lib/barback.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/barback/lib/src/asset_cascade.dart View 1 2 3 4 8 chunks +13 lines, -54 lines 0 comments Download
M pkg/barback/lib/src/barback.dart View 1 2 3 4 2 chunks +7 lines, -2 lines 0 comments Download
A pkg/barback/lib/src/build_result.dart View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
M pkg/barback/lib/src/package_graph.dart View 1 2 3 4 2 chunks +9 lines, -9 lines 0 comments Download
M pkg/barback/lib/src/phase.dart View 1 2 3 4 4 chunks +18 lines, -6 lines 0 comments Download
M pkg/barback/lib/src/transform.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/barback/lib/src/transform_node.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/barback/test/package_graph/transform_test.dart View 1 2 3 4 1 chunk +119 lines, -0 lines 0 comments Download
M pkg/barback/test/transformer/many_to_one.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/barback/test/utils.dart View 10 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
7 years, 4 months ago (2013-08-07 21:25:27 UTC) #1
Bob Nystrom
https://codereview.chromium.org/22265002/diff/6001/pkg/barback/lib/src/phase.dart File pkg/barback/lib/src/phase.dart (right): https://codereview.chromium.org/22265002/diff/6001/pkg/barback/lib/src/phase.dart#newcode192 pkg/barback/lib/src/phase.dart:192: if (id.package == cascade.package) return _inputs[id]; Can this ever ...
7 years, 4 months ago (2013-08-07 22:00:08 UTC) #2
nweiz
https://codereview.chromium.org/22265002/diff/6001/pkg/barback/lib/src/phase.dart File pkg/barback/lib/src/phase.dart (right): https://codereview.chromium.org/22265002/diff/6001/pkg/barback/lib/src/phase.dart#newcode192 pkg/barback/lib/src/phase.dart:192: if (id.package == cascade.package) return _inputs[id]; On 2013/08/07 22:00:08, ...
7 years, 4 months ago (2013-08-07 22:59:15 UTC) #3
Bob Nystrom
LGTM.
7 years, 4 months ago (2013-08-08 00:29:25 UTC) #4
nweiz
7 years, 4 months ago (2013-08-08 18:27:51 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 manually as r25937 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698