Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 22261005: Add new method to Custom Element. (Closed)

Created:
7 years, 4 months ago by Emily Fortuna
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add new method to Custom Element. BUG= Committed: https://code.google.com/p/dart/source/detail?r=25980

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/custom_element/lib/custom_element.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Emily Fortuna
7 years, 4 months ago (2013-08-09 20:53:26 UTC) #1
Jennifer Messerly
https://codereview.chromium.org/22261005/diff/1/pkg/custom_element/lib/custom_element.dart File pkg/custom_element/lib/custom_element.dart (right): https://codereview.chromium.org/22261005/diff/1/pkg/custom_element/lib/custom_element.dart#newcode400 pkg/custom_element/lib/custom_element.dart:400: bool matchesWithAncestors(String selectors) => host.matches(selectors); => host.matchesWithAncestors(selectors)?
7 years, 4 months ago (2013-08-09 20:56:16 UTC) #2
Jennifer Messerly
lgtm
7 years, 4 months ago (2013-08-09 20:57:51 UTC) #3
Emily Fortuna
7 years, 4 months ago (2013-08-09 20:58:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25980 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698