Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 222553002: Add flag --inlining-callee-size-threshold (80), that prevents inlining too large functions. (Closed)

Created:
6 years, 8 months ago by srdjan
Modified:
6 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Florian Schneider
Visibility:
Public.

Description

Add flag --inlining-callee-size-threshold (80), that prevents inlining too large functions. 'Accidentally' restores performance of NBody. Improves compilation speed (dart analyzer and stress6 test) R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=34657

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M runtime/vm/flow_graph_inliner.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
6 years, 8 months ago (2014-04-02 18:01:31 UTC) #1
Cutch
lgtm
6 years, 8 months ago (2014-04-02 18:02:09 UTC) #2
srdjan
6 years, 8 months ago (2014-04-02 18:03:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r34657 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698