Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 22253002: fix packages for latest SDK changes (Closed)

Created:
7 years, 4 months ago by Jennifer Messerly
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix packages for latest SDK changes This is the observe/mdv/custom_element side of the changes. Polymer changes are at https://chromiumcodereview.appspot.com/22254002 The big change here is we can't use a Stream for the MDV<->custom_element bridge, because Streams aren't re-entrant which makes them not useful for a sync event. Also fixes createBinding to dispatch to the custom_element so we don't need to hack "bind" in PolymerElement R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=25799

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -195 lines) Patch
M pkg/custom_element/lib/custom_element.dart View 4 chunks +2 lines, -44 lines 0 comments Download
M pkg/mdv/lib/mdv.dart View 1 2 chunks +9 lines, -4 lines 0 comments Download
M pkg/mdv/lib/src/node.dart View 1 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/mdv/lib/src/template.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/mdv/test/custom_element_bindings_test.dart View 4 chunks +28 lines, -42 lines 0 comments Download
M pkg/mdv/test/mdv_test_utils.dart View 2 chunks +3 lines, -36 lines 0 comments Download
M pkg/mdv/test/template_element_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/observe/lib/observe.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A + pkg/observe/lib/src/microtask.dart View 2 chunks +11 lines, -18 lines 0 comments Download
M pkg/observe/test/observe_test_utils.dart View 1 chunk +3 lines, -45 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
7 years, 4 months ago (2013-08-05 20:06:55 UTC) #1
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/22253002/diff/1/pkg/mdv/lib/mdv.dart File pkg/mdv/lib/mdv.dart (right): https://codereview.chromium.org/22253002/diff/1/pkg/mdv/lib/mdv.dart#newcode54 pkg/mdv/lib/mdv.dart:54: // because custom elements are not upgraded during ...
7 years, 4 months ago (2013-08-05 20:20:51 UTC) #2
Jennifer Messerly
Committed patchset #2 manually as r25799 (presubmit successful).
7 years, 4 months ago (2013-08-05 20:51:13 UTC) #3
Jennifer Messerly
7 years, 4 months ago (2013-08-05 20:51:15 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/22253002/diff/1/pkg/mdv/lib/mdv.dart
File pkg/mdv/lib/mdv.dart (right):

https://codereview.chromium.org/22253002/diff/1/pkg/mdv/lib/mdv.dart#newcode54
pkg/mdv/lib/mdv.dart:54: // because custom elements are not upgraded during
clone()
On 2013/08/05 20:20:52, Siggi Cherem (dart-lang) wrote:
> seems the same as the TODO below, remove?

Done.

https://codereview.chromium.org/22253002/diff/1/pkg/mdv/lib/mdv.dart#newcode59
pkg/mdv/lib/mdv.dart:59: Set<DocumentFragmentCreated> get instanceCreated {
On 2013/08/05 20:20:52, Siggi Cherem (dart-lang) wrote:
> an alternative pattern to consider would be to do what we did in watchers long
> time ago, where we made this registration a method and returned as a result a
> closure that unregisters the callback.

yeah, this is basically private API though that should be gone soon :)

Powered by Google App Engine
This is Rietveld 408576698