Issue 2224203002: Fix current_isolate_info_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2224203002: Fix current_isolate_info_test. (Closed)

Created:
4 years, 4 months ago by nweiz

Modified:
4 years, 4 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/package_resolver@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix current_isolate_info_test. This test didn't actually work when run with a package root rather than a package config, as is the case in Google-internal tests. R=jmesserly@google.com Committed: https://github.com/dart-lang/package_resolver/commit/8a70d3e4040b2b1ae02b585dedb620eac9e3fdb5

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -7 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/current_isolate_info_test.dart	View	3 chunks	+18 lines, -6 lines	0 comments	Download

Total messages: 4 (1 generated)

nweiz

4 years, 4 months ago (2016-08-08 23:23:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8a70d3e4040b2b1ae02b585dedb620eac9e3fdb5 (presubmit successful).