Issue 22238002: Expose arguments and options to handlers through JSONStream

Issue 22238002: Expose arguments and options to handlers through JSONStream (Closed)

Created:
7 years, 4 months ago by Cutch

Modified:
7 years, 4 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Expose arguments and options to handlers through JSONStream R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25814

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+204 lines, -49 lines)			Patch
M	runtime/vm/json_stream.h	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
M	runtime/vm/json_stream.cc	View		2 chunks	+20 lines, -0 lines	0 comments	Download
M	runtime/vm/service.cc	View		4 chunks	+102 lines, -48 lines	0 comments	Download
A +	tests/standalone/vmservice/isolate_echo_script.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A	tests/standalone/vmservice/isolate_echo_test.dart	View		1 chunk	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/22238002/diff/1/runtime/vm/json_stream.h File runtime/vm/json_stream.h (right): https://codereview.chromium.org/22238002/diff/1/runtime/vm/json_stream.h#newcode47 runtime/vm/json_stream.h:47: const char* GetArgument(intptr_t i) { const https://codereview.chromium.org/22238002/diff/1/runtime/vm/json_stream.h#newcode51 runtime/vm/json_stream.h:51: ...

7 years, 4 months ago (2013-08-06 00:02:52 UTC) #2

Cutch

https://codereview.chromium.org/22238002/diff/1/runtime/vm/json_stream.h File runtime/vm/json_stream.h (right): https://codereview.chromium.org/22238002/diff/1/runtime/vm/json_stream.h#newcode47 runtime/vm/json_stream.h:47: const char* GetArgument(intptr_t i) { On 2013/08/06 00:02:52, siva ...

7 years, 4 months ago (2013-08-06 14:46:11 UTC) #3

Cutch

7 years, 4 months ago (2013-08-06 14:46:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r25814 (presubmit successful).

Expand Messages | Collapse Messages