Issue 22227003: Adding HttpRequest method to make it easier to post form data.

Issue 22227003: Adding HttpRequest method to make it easier to post form data. (Closed)

Created:
7 years, 4 months ago by blois

Modified:
7 years, 4 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding HttpRequest method to make it easier to post form data. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=25790

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -2 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+34 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+36 lines, -2 lines	0 comments	Download
M	tests/html/xhr_test.dart	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm, with one comment tweak https://codereview.chromium.org/22227003/diff/3001/tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate File tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate (right): https://codereview.chromium.org/22227003/diff/3001/tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate#newcode58 tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate:58: * support but only ...

7 years, 4 months ago (2013-08-05 19:43:44 UTC) #2

blois

https://codereview.chromium.org/22227003/diff/3001/tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate File tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate (right): https://codereview.chromium.org/22227003/diff/3001/tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate#newcode58 tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate:58: * support but only supports string values. On 2013/08/05 ...

7 years, 4 months ago (2013-08-05 19:50:49 UTC) #3

blois

7 years, 4 months ago (2013-08-05 19:53:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r25790 (presubmit successful).

Expand Messages | Collapse Messages