Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2222603002: Look for 'number' input type, and add new assets and build (zip) script. (Closed)

Created:
4 years, 4 months ago by Pam (message me for reviews)
Modified:
4 years, 4 months ago
Reviewers:
emilyschechter, rpop, ojan
Base URL:
https://chromium.googlesource.com/chromium/extensions-by-google.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Look for 'number' input type; add new assets and build (zip) script. Look for the 'number' input field type as editable. Add new icons and Web Store promotional images, as well as a script to zip the required files. Remove executable flag from non-executable files. BUG=615448 R=ojan@chromium.org Committed: https://chromium.googlesource.com/chromium/extensions-by-google/2bf8771f46b7696475853f16f068f940174f6aee Committed: https://chromium.googlesource.com/chromium/extensions-by-google/bfa626fa788f23fc2a8bb2db4a0d8325aa00966c

Patch Set 1 #

Patch Set 2 : Don't check in an icons directory, but create it if needed #

Patch Set 3 : Remove preview #

Patch Set 4 : Edits to text files #

Patch Set 5 : Wrap text #

Patch Set 6 : site -> page #

Patch Set 7 : Tweak to readme #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M go-back-with-backspace/_locales/en/messages.json View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M go-back-with-backspace/readme.txt View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Pam (message me for reviews)
Don't check in an icons directory, but create it if needed
4 years, 4 months ago (2016-08-05 18:52:29 UTC) #1
Pam (message me for reviews)
Remove preview
4 years, 4 months ago (2016-08-05 18:54:38 UTC) #2
Pam (message me for reviews)
Ojan, please look at build-zip.sh, manifest.json and is_editable.js. The empty change to content_script.js is removing ...
4 years, 4 months ago (2016-08-05 19:00:36 UTC) #5
ojan
lgtm
4 years, 4 months ago (2016-08-09 16:45:42 UTC) #6
Pam (message me for reviews)
Edits to text files
4 years, 4 months ago (2016-08-09 17:31:43 UTC) #7
Pam (message me for reviews)
Committed patchset #6 (id:100001) manually as 2bf8771f46b7696475853f16f068f940174f6aee (presubmit successful).
4 years, 4 months ago (2016-08-09 17:42:42 UTC) #9
Pam (message me for reviews)
4 years, 4 months ago (2016-08-09 17:56:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
bfa626fa788f23fc2a8bb2db4a0d8325aa00966c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698