Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 222223004: pkg/docgen: continue the refactoring (Closed)

Created:
6 years, 8 months ago by kevmoo
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/docgen: continue the refactoring R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=34651

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -202 lines) Patch
M pkg/docgen/lib/src/model_helpers.dart View 2 chunks +133 lines, -4 lines 0 comments Download
M pkg/docgen/lib/src/models.dart View 22 chunks +62 lines, -198 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo
Continue refactoring work...hoping this will make bug fixing and testing easier
6 years, 8 months ago (2014-04-02 16:15:23 UTC) #1
Emily Fortuna
lgtm, one suggestion https://codereview.chromium.org/222223004/diff/1/pkg/docgen/lib/src/models.dart File pkg/docgen/lib/src/models.dart (right): https://codereview.chromium.org/222223004/diff/1/pkg/docgen/lib/src/models.dart#newcode29 pkg/docgen/lib/src/models.dart:29: String toString() => "${super.toString()} - $mirror"; ...
6 years, 8 months ago (2014-04-02 16:33:49 UTC) #2
kevmoo
https://codereview.chromium.org/222223004/diff/1/pkg/docgen/lib/src/models.dart File pkg/docgen/lib/src/models.dart (right): https://codereview.chromium.org/222223004/diff/1/pkg/docgen/lib/src/models.dart#newcode29 pkg/docgen/lib/src/models.dart:29: String toString() => "${super.toString()} - $mirror"; On 2014/04/02 16:33:49, ...
6 years, 8 months ago (2014-04-02 16:35:14 UTC) #3
kevmoo
6 years, 8 months ago (2014-04-02 16:36:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r34651 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698