Issue 221943002: Speed up snapshots of *int8lists, by using memmove.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 221943002: Speed up snapshots of *int8lists, by using memmove. (Closed)

Created:
6 years, 8 months ago by Anders Johnsen

Modified:
6 years, 8 months ago

Reviewers:
Søren Gjesse, siva, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Speed up snapshots of *int8lists, by using memmove. BUG=https://code.google.com/p/dart/issues/detail?id=17951 R=asiva@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34649

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -21 lines)			Patch
	M	runtime/vm/dart_api_message.cc	View		2 chunks	+25 lines, -7 lines	0 comments	Download
	M	runtime/vm/raw_object_snapshot.cc	View		3 chunks	+10 lines, -14 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #1 manually as r34649 (presubmit successful).

6 years, 8 months ago (2014-04-02 15:53:31 UTC) #4

Ivan Posva

6 years, 8 months ago (2014-04-03 05:41:01 UTC) #5

Message was sent while issue was closed.

DBC -ip

https://codereview.chromium.org/221943002/diff/1/runtime/vm/raw_object_snapsh...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/221943002/diff/1/runtime/vm/raw_object_snapsh...
runtime/vm/raw_object_snapshot.cc:2344: case kTypedDataFloat32ArrayCid:
You should consider doing the same for Float32 and Float64 at least. They don't
compress very well using the current compression algorithm, which has been tuned
for small integer values.

Expand Messages | Collapse Messages