Issue 22183002: Forwarding constructors are never const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22183002: Forwarding constructors are never const (Closed)

Created:
7 years, 4 months ago by hausner

Modified:
7 years, 4 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Forwarding constructors are never const Forwarding constructors of mixing application classes do not inherit the super constructor's const-ness. They are also never abstract or external. Fixes issue 11917. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=25765

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -7 lines)			Patch
	M	runtime/vm/class_finalizer.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	tests/language/language.status	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/22183002/diff/1/tests/language/language.status File tests/language/language.status (right): https://codereview.chromium.org/22183002/diff/1/tests/language/language.status#newcode79 tests/language/language.status:79: ###const_constructor_mixin_test/01: Fail # Issue 11917 Do you want ...

7 years, 4 months ago (2013-08-05 11:52:02 UTC) #2

hausner

Thank you. https://codereview.chromium.org/22183002/diff/1/tests/language/language.status File tests/language/language.status (right): https://codereview.chromium.org/22183002/diff/1/tests/language/language.status#newcode79 tests/language/language.status:79: ###const_constructor_mixin_test/01: Fail # Issue 11917 On 2013/08/05 ...

7 years, 4 months ago (2013-08-05 11:55:21 UTC) #3

hausner

7 years, 4 months ago (2013-08-05 12:13:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r25765 (presubmit successful).

Expand Messages | Collapse Messages