Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 221813011: [web_components] update web_components and polymer.js (Closed)

Created:
6 years, 8 months ago by Jennifer Messerly
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+931 lines, -797 lines) Patch
M pkg/polymer/lib/src/js/polymer/build.log View 1 1 chunk +17 lines, -23 lines 0 comments Download
M pkg/polymer/lib/src/js/polymer/polymer.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/polymer/lib/src/js/polymer/polymer.concat.js View 1 28 chunks +249 lines, -214 lines 0 comments Download
M pkg/polymer/lib/src/js/polymer/polymer.concat.js.map View 1 2 chunks +11 lines, -11 lines 0 comments Download
M pkg/polymer/lib/src/js/polymer/polymer.js.map View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/src/js/use_native_dartium_shadowdom.js View 1 1 chunk +19 lines, -0 lines 1 comment Download
M pkg/web_components/lib/build.log View 1 1 chunk +26 lines, -31 lines 0 comments Download
M pkg/web_components/lib/platform.js View 1 1 chunk +8 lines, -7 lines 0 comments Download
M pkg/web_components/lib/platform.concat.js View 1 102 chunks +598 lines, -508 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
https://codereview.chromium.org/221813011/diff/10001/pkg/polymer/lib/src/js/use_native_dartium_shadowdom.js File pkg/polymer/lib/src/js/use_native_dartium_shadowdom.js (right): https://codereview.chromium.org/221813011/diff/10001/pkg/polymer/lib/src/js/use_native_dartium_shadowdom.js#newcode15 pkg/polymer/lib/src/js/use_native_dartium_shadowdom.js:15: var proto = Element.prototype; this is the new change. ...
6 years, 8 months ago (2014-04-02 23:43:49 UTC) #1
Siggi Cherem (dart-lang)
lgtm
6 years, 8 months ago (2014-04-02 23:45:55 UTC) #2
Jennifer Messerly
6 years, 8 months ago (2014-04-02 23:47:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r34676 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698