Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 221733002: Don't run "git fetch" multiple times for the same repository. (Closed)

Created:
6 years, 8 months ago by nweiz
Modified:
6 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't run "git fetch" multiple times for the same repository. When looking into issue 17854, I noticed that when installing without a locked git revision, "pub get" was running "git fetch" over and over again on the same repository. This avoids doing so and increases the speed of "pub get" with git repositories considerably. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=34671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M sdk/lib/_internal/pub/lib/src/source/git.dart View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 8 months ago (2014-04-02 00:54:29 UTC) #1
Bob Nystrom
LGTM. Very nice.
6 years, 8 months ago (2014-04-02 21:03:24 UTC) #2
nweiz
6 years, 8 months ago (2014-04-02 21:05:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34671 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698