Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 221483002: Fix for translation of \!= to \!identical(), but use == and \!= for Enum. (Closed)

Created:
6 years, 8 months ago by scheglov
Modified:
6 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for translation of \!= to \!identical(), but use == and \!= for Enum. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=34636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2599 lines, -2791 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 5 chunks +41 lines, -9 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java View 2 chunks +92 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java View 3 chunks +73 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 119 chunks +133 lines, -311 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 32 chunks +53 lines, -93 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 44 chunks +111 lines, -157 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 165 chunks +551 lines, -552 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 177 chunks +364 lines, -436 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 38 chunks +64 lines, -104 lines 0 comments Download
M pkg/analyzer/lib/src/generated/index.dart View 24 chunks +53 lines, -95 lines 0 comments Download
M pkg/analyzer/lib/src/generated/instrumentation.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 2 chunks +5 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 46 chunks +218 lines, -250 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 148 chunks +312 lines, -316 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 44 chunks +204 lines, -269 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 19 chunks +72 lines, -52 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 9 chunks +20 lines, -35 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_collection.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_dart.dart View 1 chunk +6 lines, -8 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 4 chunks +21 lines, -21 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 19 chunks +173 lines, -33 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 4 chunks +8 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 4 chunks +6 lines, -7 lines 0 comments Download
M pkg/code_transformers/test/resolver_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_analyzer2.status View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 8 months ago (2014-04-01 21:16:59 UTC) #1
Brian Wilkerson
LGTM!
6 years, 8 months ago (2014-04-01 22:56:28 UTC) #2
scheglov
6 years, 8 months ago (2014-04-02 03:09:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34636 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698