Reorganize the dart2js transformer tests.

Reorganize the dart2js transformer tests.

Aside from tweaking a bit of whitespace and consolidating a couple
of tests, there are no substantive changes here.

R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34673

[Bob Nystrom, 2014-04-02 18:07:15]

I still think there's more work we could do here (in particular, having some
coherent strategy for prefering pub build, pub serve, or both, for any given
test), but I wanted to separate out the moves from other changes to make it
easier to review.

[nweiz, 2014-04-02 19:32:56]

I'd kind of like all of the barback stuff to be in a single test directory so
it's easy to run all of them without running the rest of the pub tests as well.

https://codereview.chromium.org/221413007/diff/1/sdk/lib/_internal/pub/test/t...
File
sdk/lib/_internal/pub/test/transformer/mode_defaults_to_debug_in_serve_test.dart
(left):

https://codereview.chromium.org/221413007/diff/1/sdk/lib/_internal/pub/test/t...
sdk/lib/_internal/pub/test/transformer/mode_defaults_to_debug_in_serve_test.dart:1:
// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS d.file
Where did this test and its twin end up?

[Bob Nystrom, 2014-04-02 20:28:52]

> I'd kind of like all of the barback stuff to be in a single test directory so
it's easy to run all of them without running the rest of the pub tests as well.

I'd initially gone in that direction (hence "transformers/dart2js", etc.) but I
find it a real pain in practice. I should have known this already, but a
hierarchy isn't a good fit here. Given that, I want to just flatten things out
to probably a single level of directories.

If I were writing a test runner, it would support tagging tests and running all
tests matching a tag.

In the absence of that, I think one approach to running all the barback tests
is:

./tools/test.dart -m release "pub/build|serve|dart2js|transformer"

Believe it or not, that actually works and (sort of) does what you want. It runs
any test in pub whose full path matches "build|serve|dart2js|transformer".

https://codereview.chromium.org/221413007/diff/1/sdk/lib/_internal/pub/test/t...
File
sdk/lib/_internal/pub/test/transformer/mode_defaults_to_debug_in_serve_test.dart
(left):

https://codereview.chromium.org/221413007/diff/1/sdk/lib/_internal/pub/test/t...
sdk/lib/_internal/pub/test/transformer/mode_defaults_to_debug_in_serve_test.dart:1:
// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS d.file
On 2014/04/02 19:32:57, nweiz wrote:
> Where did this test and its twin end up?

It turns out this test was completely redundant. See
serve/defaults_to_debug_mode_test.dart and
build/defaults_to_release_mode_test.dart.

I left the ones under their respective commands because that's where the code
that implements the tested functionality is.

[nweiz, 2014-04-02 20:42:44]

I think we're going to end up going back to a hierarchical organization once the
full test runtime becomes too long to bear, but lgtm.

[Bob Nystrom, 2014-04-02 21:43:39]

Committed patchset #1 manually as r34673 (presubmit successful).