Don't fetch git repository unnecessarily when running "pub get".

Don't fetch git repository unnecessarily when running "pub get".

R=rnystrom@google.com
BUG=17854
RELNOTE=Don't fetch git repository unnecessarily when running "pub get".

Committed: https://code.google.com/p/dart/source/detail?r=34626

[Bob Nystrom, 2014-04-01 23:43:34]

lgtm

https://codereview.chromium.org/221383002/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/git.dart (right):

https://codereview.chromium.org/221383002/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/git.dart:15: class GitException implements
Exception {
I think we tend to import this library with a prefix. "git.GitException" seems
weird to me, but then calling it "Exception" is a bit odd too. Thoughts?

[nweiz, 2014-04-02 00:41:19]

https://codereview.chromium.org/221383002/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/git.dart (right):

https://codereview.chromium.org/221383002/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/git.dart:15: class GitException implements
Exception {
On 2014/04/01 23:43:34, Bob Nystrom wrote:
> I think we tend to import this library with a prefix. "git.GitException" seems
> weird to me, but then calling it "Exception" is a bit odd too. Thoughts?

I think shadowing core types is worse than having a redundant prefix, although I
sure wish the core library didn't use both Exception *and* Error, since it gives
prefixed libraries nowhere else to go.

[nweiz, 2014-04-02 00:47:31]

Committed patchset #2 manually as r34626 (presubmit successful).