Issue 221333004: Fix a few remaining synchronous uses of BuildDirectory.server.

Issue 221333004: Fix a few remaining synchronous uses of BuildDirectory.server. (Closed)

Created:
6 years, 8 months ago by nweiz

Modified:
6 years, 8 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a few remaining synchronous uses of BuildDirectory.server. R=rnystrom@google.com TBR Committed: https://code.google.com/p/dart/source/detail?r=34634

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -44 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/barback/build_environment.dart	View	3 chunks	+20 lines, -12 lines	2 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/old_web_socket_api.dart	View	2 chunks	+17 lines, -16 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart	View	1 chunk	+17 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #1 manually as r34634 (presubmit successful).

6 years, 8 months ago (2014-04-02 02:24:32 UTC) #2

Bob Nystrom

https://codereview.chromium.org/221333004/diff/1/sdk/lib/_internal/pub/lib/src/barback/build_environment.dart File sdk/lib/_internal/pub/lib/src/barback/build_environment.dart (right): https://codereview.chromium.org/221333004/diff/1/sdk/lib/_internal/pub/lib/src/barback/build_environment.dart#newcode306 sdk/lib/_internal/pub/lib/src/barback/build_environment.dart:306: return syncFuture(iterate); Optimizing to not short-circuit walking the whole ...

6 years, 8 months ago (2014-04-02 17:31:31 UTC) #3

nweiz

6 years, 8 months ago (2014-04-02 20:21:27 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/221333004/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/build_environment.dart (right):

https://codereview.chromium.org/221333004/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/build_environment.dart:306: return
syncFuture(iterate);
On 2014/04/02 17:31:31, Bob Nystrom wrote:
> Optimizing to not short-circuit walking the whole list seems like overkill
here.
> How about just using:
> 
> return Future.wait(_directories.map((dir) => dir.server).then((servers) { ...
> });

Done.

Expand Messages | Collapse Messages