Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 221173008: Use shelf for some of pub's servers. (Closed)

Created:
6 years, 8 months ago by nweiz
Modified:
6 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, kevmoo
Visibility:
Public.

Description

Use shelf for some of pub's servers. The barback servers haven't yet been converted, since shelf/websocket integration is still being figured out. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=34679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -53 lines) Patch
M sdk/lib/_internal/pub/lib/src/oauth2.dart View 3 chunks +26 lines, -23 lines 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 2 chunks +13 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 8 months ago (2014-04-02 03:18:59 UTC) #1
Bob Nystrom
lgtm
6 years, 8 months ago (2014-04-02 23:57:53 UTC) #2
nweiz
6 years, 8 months ago (2014-04-03 00:48:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34679 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698