Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 220863003: Don't make the signal-pipe non-blocking. (Closed)

Created:
6 years, 8 months ago by Anders Johnsen
Modified:
6 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org, zra
Visibility:
Public.

Description

Don't make the signal-pipe non-blocking. This is an attempt to make it run on MIPS. The non-blocking is not needed here. BUG=https://code.google.com/p/dart/issues/detail?id=17826 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34594

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M runtime/bin/process_linux.cc View 2 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 8 months ago (2014-04-01 11:32:11 UTC) #1
Søren Gjesse
lgtm
6 years, 8 months ago (2014-04-01 11:58:11 UTC) #2
Anders Johnsen
6 years, 8 months ago (2014-04-01 12:15:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r34594 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698