Add optimization for pow(base, 0.5) to the other architectures as well.

Add optimization for pow(base, 0.5) to the other architectures as well.

R=zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34717

[zra, 2014-04-03 17:04:46]

lgtm with small fixes.

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4954: __ LoadObject(temp,
Double::ZoneHandle(Double::NewCanonical(0)));
__ LoadDImmediate(DTMP, 0.0);

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4956: __ LoadObject(temp,
Double::ZoneHandle(Double::NewCanonical(1)));
__ LoadDImmediate(result, 1.0);

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4976: __ LoadObject(temp,
Double::ZoneHandle(Double::NewCanonical(NAN)));
__ LoadDImmediate(result, NAN);

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4981: __ Bind(&do_call);
Maybe rename label since we're checking for 0.5 now before calling.

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4983: // Before calling check if we
could use sqrt instead of pow.
Before calling,

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4984: __ LoadObject(temp,
Double::ZoneHandle(Double::NewCanonical(-INFINITY)));
__ LoadDImmediate(result, -INFINITY);

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4991: __ LoadObject(temp,
Double::ZoneHandle(Double::NewCanonical(0.5)));
__ LoadDImmediate(result, 0.5);

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_mips.cc (right):

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_mips.cc:3721: __ LoadObject(TMP,
Double::ZoneHandle(Double::NewCanonical(0)));
__ LoadImmediate(DTMP, 0.0);

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_mips.cc:3723: __ LoadObject(TMP,
Double::ZoneHandle(Double::NewCanonical(1)));
__ LoadImmediate(result, 1.0);

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_mips.cc:3743: __ LoadObject(TMP,
Double::ZoneHandle(Double::NewCanonical(NAN)));
__ LoadImmediate(result, NAN);

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_mips.cc:3750: __ LoadObject(TMP,
Double::ZoneHandle(Double::NewCanonical(INFINITY)));
__ LoadImmediate(result, INFINITY);

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_mips.cc:3757: __ LoadObject(TMP,
Double::ZoneHandle(Double::NewCanonical(0.5)));
__ LoadImmediate(result, 0.5);

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_mips.cc:3781: 
extra line

https://codereview.chromium.org/220723017/diff/1/tests/lib/math/double_pow_te...
File tests/lib/math/double_pow_test.dart (right):

https://codereview.chromium.org/220723017/diff/1/tests/lib/math/double_pow_te...
tests/lib/math/double_pow_test.dart:4: //
VMOptions=--optimization-counter-threshold=10
Maybe also add a loop to ensure that this is being hit for all test cases.

[srdjan, 2014-04-03 19:33:18]

Thanks.

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4954: __ LoadObject(temp,
Double::ZoneHandle(Double::NewCanonical(0)));
On 2014/04/03 17:04:46, zra wrote:
> __ LoadDImmediate(DTMP, 0.0);

Done.

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4956: __ LoadObject(temp,
Double::ZoneHandle(Double::NewCanonical(1)));
On 2014/04/03 17:04:46, zra wrote:
> __ LoadDImmediate(result, 1.0);

Done.

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4976: __ LoadObject(temp,
Double::ZoneHandle(Double::NewCanonical(NAN)));
On 2014/04/03 17:04:46, zra wrote:
> __ LoadDImmediate(result, NAN);

Done.

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4981: __ Bind(&do_call);
On 2014/04/03 17:04:46, zra wrote:
> Maybe rename label since we're checking for 0.5 now before calling.

Renamed to try_sqrt

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4983: // Before calling check if we
could use sqrt instead of pow.
On 2014/04/03 17:04:46, zra wrote:
> Before calling,

Done.

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4984: __ LoadObject(temp,
Double::ZoneHandle(Double::NewCanonical(-INFINITY)));
On 2014/04/03 17:04:46, zra wrote:
> __ LoadDImmediate(result, -INFINITY);

Done.

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4991: __ LoadObject(temp,
Double::ZoneHandle(Double::NewCanonical(0.5)));
On 2014/04/03 17:04:46, zra wrote:
> __ LoadDImmediate(result, 0.5);

Done.

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_mips.cc (right):

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_mips.cc:3721: __ LoadObject(TMP,
Double::ZoneHandle(Double::NewCanonical(0)));
On 2014/04/03 17:04:46, zra wrote:
> __ LoadImmediate(DTMP, 0.0);

Done.

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_mips.cc:3723: __ LoadObject(TMP,
Double::ZoneHandle(Double::NewCanonical(1)));
On 2014/04/03 17:04:46, zra wrote:
> __ LoadImmediate(result, 1.0);

Done.

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_mips.cc:3743: __ LoadObject(TMP,
Double::ZoneHandle(Double::NewCanonical(NAN)));
On 2014/04/03 17:04:46, zra wrote:
> __ LoadImmediate(result, NAN);

Done.

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_mips.cc:3750: __ LoadObject(TMP,
Double::ZoneHandle(Double::NewCanonical(INFINITY)));
On 2014/04/03 17:04:46, zra wrote:
> __ LoadImmediate(result, INFINITY);

Done.

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_mips.cc:3757: __ LoadObject(TMP,
Double::ZoneHandle(Double::NewCanonical(0.5)));
On 2014/04/03 17:04:46, zra wrote:
> __ LoadImmediate(result, 0.5);

Done.

https://codereview.chromium.org/220723017/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_mips.cc:3781: 
On 2014/04/03 17:04:46, zra wrote:
> extra line

Done.

https://codereview.chromium.org/220723017/diff/1/tests/lib/math/double_pow_te...
File tests/lib/math/double_pow_test.dart (right):

https://codereview.chromium.org/220723017/diff/1/tests/lib/math/double_pow_te...
tests/lib/math/double_pow_test.dart:4: //
VMOptions=--optimization-counter-threshold=10
On 2014/04/03 17:04:46, zra wrote:
> Maybe also add a loop to ensure that this is being hit for all test cases.

Done.

[srdjan, 2014-04-03 19:44:23]

Committed patchset #2 manually as r34717 (presubmit successful).