Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Issue 220703003: Always print the runtime as part of the stepname (Closed)

Created:
6 years, 8 months ago by ricow1
Modified:
6 years, 8 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Always print the runtime as part of the stepname BUG:17919 R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34592

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M tools/bots/compiler.py View 1 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 8 months ago (2014-04-01 09:28:09 UTC) #1
Bill Hesse
lgtm https://codereview.chromium.org/220703003/diff/1/tools/bots/compiler.py File tools/bots/compiler.py (right): https://codereview.chromium.org/220703003/diff/1/tools/bots/compiler.py#newcode270 tools/bots/compiler.py:270: TestStep('%s' % compiler, mode, system, compiler, Is '%s' ...
6 years, 8 months ago (2014-04-01 12:04:03 UTC) #2
ricow1
https://codereview.chromium.org/220703003/diff/1/tools/bots/compiler.py File tools/bots/compiler.py (right): https://codereview.chromium.org/220703003/diff/1/tools/bots/compiler.py#newcode270 tools/bots/compiler.py:270: TestStep('%s' % compiler, mode, system, compiler, On 2014/04/01 12:04:03, ...
6 years, 8 months ago (2014-04-01 12:07:34 UTC) #3
ricow1
6 years, 8 months ago (2014-04-01 12:07:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r34592 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698