Issue 22054002: Fixed io string transformer test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22054002: Fixed io string transformer test (Closed)

Created:
7 years, 4 months ago by kevmoo-old

Modified:
7 years, 4 months ago

Reviewers:
Lasse Reichstein Nielsen, floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fixed io string transformer test close was not being called, close value check was incorrect R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=26085

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -74 lines)			Patch
	M	tests/standalone/io/string_transformer_test.dart	View	1 2 3 4 5 6	5 chunks	+34 lines, -74 lines	0 comments	Download

Total messages: 3 (0 generated)

kevmoo-old

Close was never being called, so nothing was being tested.

7 years, 4 months ago (2013-08-03 20:28:58 UTC) #1

kevmoo-old

7 years, 4 months ago (2013-08-13 21:29:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #7 manually as r26085 (presubmit successful).